Closed sonictl closed 1 year ago
myWire.begin(SDA, SCL);
is not a standard Arduino Wire library method:
https://www.arduino.cc/reference/en/language/functions/communication/wire/begin/
Are you working with ESP32?
But how to specify I2C PIN if they're different from the default(4U, 5U) in this example code? I'm using esp8266. pls see line56 of https://github.com/esp8266/Arduino/blob/master/libraries/Wire/Wire.h
Support needs to be added in the ESP8266 core. This is equivalent to the same issue that arises when using ESP32. See here for how that was dealt with: https://github.com/espressif/arduino-esp32/issues/3779
Try opening an issue with the ESP8266 core.
add support for PIN_SDA, PIN_SCL specifying for user's board.
Thank you for creating a pull request to contribute to Adafruit's GitHub code! Before you open the request please review the following guidelines and tips to help it be more easily integrated:
Describe the scope of your change--i.e. what the change does and what parts of the code were modified. This will help us understand any risks of integrating the code.
Describe any known limitations with your change. For example if the change doesn't apply to a supported platform of the library please mention it.
Please run any tests or examples that can exercise your modified code. We strive to not break users of the code and running tests/examples helps with this process.
Thank you again for contributing! We will try to test and integrate the change as soon as we can, but be aware we have many GitHub repositories to manage and can't immediately respond to every request. There is no need to bump or check in on a pull request (it will clutter the discussion of the request).
Also don't be worried if the request is closed or not integrated--sometimes the priorities of Adafruit's GitHub code (education, ease of use) might not match the priorities of the pull request. Don't fret, the open source community thrives on forks and GitHub makes it easy to keep your changes in a forked repo.
After reviewing the guidelines above you can delete this text from the pull request.