Improve touchRead delay/retry handling

adafruit / Adafruit_Seesaw

Arduino library driver for seesaw multi-use chip

93 stars 64 forks source link

Improve touchRead delay/retry handling #27

Closed tmm1 closed 3 years ago

tmm1 commented 4 years ago

Alternative to #25

fixes infinite loop stall in touchRead when sensor is not connected
avoids delays and read attempts if the i2c transaction fails (checking return value of endTransaction())
fixes touchRead(0) not working with latest soil sensor firmware which requires a longer delay
improves logging when SEESAW_I2C_DEBUG is enabled to cover retries and failure modes

cc @ladyada @mihai-dinculescu

mihai-dinculescu commented 4 years ago

It seems to work very similarly with master, but this version is obviously a lot more reliable than what's in there.

I still get fairly large differences between reads, but I get them when increasing the delay as well so I suppose that is that.

Sadly this sensor still has a lot of issues left (it feels more like a touch sensor instead of a moisture sensor) so I have taken it out of my project.

tmm1 commented 4 years ago

Bummer. Did you switch to a different sensor?

mihai-dinculescu commented 4 years ago

I'm trying out a Gravity Capacitive Analog Sensor. It looks promising so far.

tmm1 commented 4 years ago

I'm trying out a Gravity Capacitive Analog Sensor. It looks promising so far.

Thanks, I'll check it out.

Sadly this sensor still has a lot of issues left (it feels more like a touch sensor instead of a moisture sensor) so I have taken it out of my project.

Can you elaborate on what other issues you ran into? I'm evaluating different soil sensors as well so it would be helpful to understand what other problems you encountered.

mihai-dinculescu commented 4 years ago

I'm trying out a Gravity Capacitive Analog Sensor. It looks promising so far.

Thanks, I'll check it out.

Sadly this sensor still has a lot of issues left (it feels more like a touch sensor instead of a moisture sensor) so I have taken it out of my project.

Can you elaborate on what other issues you ran into? I'm evaluating different soil sensors as well so it would be helpful to understand what other problems you encountered.

Here are some links to issues raised by other people that I'm also encountering. I love Adafruit products and I have a lot of them, but this specific sensor seems to fail miserably at it's job.

https://forums.adafruit.com/viewtopic.php?f=19&t=152792 https://forums.adafruit.com/viewtopic.php?f=8&t=157971 https://forums.adafruit.com/viewtopic.php?f=57&t=156823

tmm1 commented 4 years ago

Thanks for the links. That's quite helpful to know that others are also seeing the 1015 max value and I'm not going crazy.

I will be curious to hear how you get on with the DFRobot sensor. I think I will try this one: https://www.tindie.com/products/miceuz/i2c-soil-moisture-sensor/

mihai-dinculescu commented 4 years ago

The DFRobot sensor worked very well for a few weeks (apart from the regular issues that come when using analog sensors) and then it died. I suppose that it was mostly my fault, for not waterproofing it.

I've just got a Catnip rugged sensor. It works fine so far. Fingers crossed that it will continue working well.

tmm1 commented 4 years ago

I've been using the rugged catnip sensor for a few weeks and it works very well.

3943307C-DD49-474C-8DCA-84FA1B225B98