adafruit / Adafruit_Si5351_Library

Driver for Adafruit's Si5351 Clockgen Breakout
43 stars 30 forks source link

divider is limited to 3 < div < 901 while AN619 and AN1234 state a range of 8+1/xxx to 2048 #8

Closed thefloe1 closed 3 years ago

thefloe1 commented 3 years ago

https://github.com/adafruit/Adafruit_Si5351_Library/blob/f0e1b4a4d7acdb29b26e11c23665e66e28f3fe2f/Adafruit_SI5351.cpp#L401

divider is limited to 3 < div < 901 while AN619 and AN1234 state a range of 8+1/xxx to 2048

sx107 commented 3 years ago

Not exactly. AN619. page 2:

Valid Multisynth divider ratios are 4, 6, 8, and any fractional value between 8 + 1/1,048,575 and 2048.

Multisynth integer divisor can be less than 8: 4 or 6. In my experience, 4 or 6 works if the fractional part is set to 0/1, regardless of the multisynth working in fractional or integer mode.

thefloe1 commented 3 years ago

right, sorry marked the wrong line here. Should have been line 402 and the upper limit is the main concern:

https://github.com/adafruit/Adafruit_Si5351_Library/blob/f0e1b4a4d7acdb29b26e11c23665e66e28f3fe2f/Adafruit_SI5351.cpp#L402

caternuson commented 3 years ago

Related: https://github.com/adafruit/Adafruit_CircuitPython_SI5351/issues/18

thefloe1 commented 3 years ago

I created a pull request to change the upper limit to 2048

stoltzmr commented 3 years ago

Hi Team, how can this update also be applied to Arduino Library? It has been updated in Raspberry Pi library v 1.2.7.

ladyada commented 3 years ago

you can test this PR https://github.com/adafruit/Adafruit_Si5351_Library/pull/10/files

stoltzmr commented 3 years ago

This works! Thanks so much @ladyada