search

adafruit / Adafruit_Si5351_Library

Driver for Adafruit's Si5351 Clockgen Breakout
43 stars 30 forks source link

Useless example clockbuilder test setup occupying too much both code and firmware space #9

Open sx107 opened 3 years ago

sx107 commented 3 years ago

Probably, the example m_si5351_regs_15to92_149to170 array should be cut? Moving it into an example would make much more sense. Moreover, the exact format of this array is not an exact output from the clockBuilder app (it outputs everything without {} brackets), perhaps it would be a good idea to expect a {REG_ADDR, REG_VAL, REG_ADDR, REG_VAL...} format instead of current {{REG_ADDR, REG_VAL}, {REG_ADDR, REG_VAL}}? It is much easier to convert to from the clockbuilder output text file (by just adding commas after every line and brackets in beginning and end)?

ladyada commented 3 years ago

sure if you want to submit a non-breaking PR we'll take a look