search

adafruit / Adafruit_Si7021

Arduino library for Adafruit Si7021
34 stars 28 forks source link

Added functionality #17

Closed LunarKitsune closed 4 years ago

LunarKitsune commented 4 years ago

Small list of changes requested for the pull request: 1: Added conversion function for converting Celsius to Fahrenheit called convertToF() 2: Due to number one: also added an optional bool parameter to readTemperature() -This will let a programmer choose if the temperature output is Celsius or Fahrenheit 3: Fixed readHumidity function so it returns 0 if below 0 (this will be tested once I get the product in. Adafruit_Si7021Changes.zip

ladyada commented 4 years ago

hmm can you try making a fresh PR based off 'master' branch? the files all changed and its hard to tell what ya added :)

LunarKitsune commented 4 years ago

Sure. Ill be able to later. I tried adding the main header file and the main cpp file and it wasnt letting me earlier.

LunarKitsune commented 4 years ago

My apologies ladyada. It won't let me create a new PR request as the button is dulled out and non functional when I have master selected. It was the reason I selected "actionci from master" when I submitted it.

ladyada commented 4 years ago

your PR should be from your fork master to this repo.

LunarKitsune commented 4 years ago

Thank you for the patience. Im decent at coding, but not decent enough at github and it clicked with me after you said that. :) New pull request should be put in now. This pull request will be closed.