search

adafruit / Adafruit_TLC5947

Adafruit's Arduino driver for the TLC5947
http://www.adafruit.com/products/1429
Other
40 stars 22 forks source link

Update tlc5947test.ino #13

Closed AlanGitMan closed 1 year ago

AlanGitMan commented 1 year ago

Changed NUM_TLC5974 to NUM_TLC5947 throughout. This was not causing any functional problem cos the name was wrong everywhere, but it might be confusing for new users trying to understand the code.

caternuson commented 1 year ago

Need to also change the reference used in this line:

Adafruit_TLC5947 tlc = Adafruit_TLC5947(NUM_TLC5974, clock, data, latch);

(the typo is still there)

caternuson commented 1 year ago

Your last push looked good. But then you closed the PR and deleted the branch before it was merged. Was that intentional?

AlanGitMan commented 1 year ago

No, I got a bit lost and ended up closing it instead of committing it – not used to using github – shall I start again or can you do it?

From: Carter Nelson @.> Sent: 17 January 2023 20:22 To: adafruit/Adafruit_TLC5947 @.> Cc: AlanGitMan @.>; State change @.> Subject: Re: [adafruit/Adafruit_TLC5947] Update tlc5947test.ino (PR #13)

Your last push looked good. But then you closed the PR and deleted the branch before it was merged. Was that intentional?

— Reply to this email directly, view it on GitHub https://github.com/adafruit/Adafruit_TLC5947/pull/13#issuecomment-1386003553 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ACISC7MXRS6T3X6T5FLJK33WS35QBANCNFSM6AAAAAAT6CR3N4 . You are receiving this because you modified the open/close state.Message ID: @.***>

caternuson commented 1 year ago

Up to you. This is a pretty simple code change, so is a good one to practice the whole PR process. Even simple code changes need to go through the same process as any PR. It was actually good from a learning experience point of view your first submit failed (see the red X). Good practice scenario to find why it failed (it's what I mentioned above) and then push new updates to try and get things to pass (the green check).

But if you'd rather not deal with another PR, we can take care of it. If you want to try again, totally fine to just submit a new PR.

AlanGitMan commented 1 year ago

PR renewed and verified

From: Carter Nelson @.> Sent: 17 January 2023 22:19 To: adafruit/Adafruit_TLC5947 @.> Cc: AlanGitMan @.>; State change @.> Subject: Re: [adafruit/Adafruit_TLC5947] Update tlc5947test.ino (PR #13)

Up to you. This is a pretty simple code change, so is a good one to practice the whole PR process. Even simple code changes need to go through the same process as any PR. It was actually good from a learning experience point of view your first submit failed (see the red X). Good practice scenario to find why it failed (it's what I mentioned above) and then push new updates to try and get things to pass (the green check).

But if you'd rather not deal with another PR, we can take care of it. If you want to try again, totally fine to just submit a new PR.

— Reply to this email directly, view it on GitHub https://github.com/adafruit/Adafruit_TLC5947/pull/13#issuecomment-1386159260 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ACISC7OOTIDTHDBEN57SHG3WS4LGZANCNFSM6AAAAAAT6CR3N4 . You are receiving this because you modified the open/close state.Message ID: @.***>