search

adafruit / Adafruit_TSL2561

Unified sensor driver for Adafruit's TSL2561 breakouts
85 stars 77 forks source link

Code Beautifications #14

Closed sethtroisi closed 5 years ago

sethtroisi commented 6 years ago

Scope: Code beautification, no op in behavior known limitations: None Testing plan: Ran example .ino on my Arduino using this code of library

ladyada commented 6 years ago

hiya these look good, want to take a look at the remaining errors/complaints? looks like the esp32 compiler is warning on a lot :)

sethtroisi commented 5 years ago

When I first submitted this there were other warnings (that required changes I didn't have a plan to test (see https://github.com/adafruit/Adafruit_TSL2561/compare/master...sethtroisi:warnings)) but now it appears to be happy with these style changes.

ladyada commented 5 years ago

thanx!

sethtroisi commented 5 years ago

Thanks for letting me merge upstream in an older repo :)

IMG_20190403_145843

ladyada commented 5 years ago

wow, this is our first github thank you note! thanks for the commits :)