adafruit / Adafruit_TSL2561

Unified sensor driver for Adafruit's TSL2561 breakouts
87 stars 77 forks source link

Added support for Teensy 3.x and made Wire port selectable in setup #9

Closed mjs513 closed 7 years ago

mjs513 commented 7 years ago

Thanks for considering this change Mike

ladyada commented 7 years ago

hiya please remove example where you change Wire2, the examples should not change behavior :)

have you tested with arduino UNO?

mjs513 commented 7 years ago

I reverted to tsl.begin in the example and added a comment on how to use for other Wire buses. I did not connect the sensor up but I did a compile with no errors for begin() and begin(&Wire). I can dig it out to give it a try.

ladyada commented 7 years ago

please do :) it will help us a lot!

mjs513 commented 7 years ago

Ok. Tested with Uno, Mega and Due using &Wire1. Worked fine. :) Really had to go fine the uno and due boards - didn't use them for a while. I am also making similar changes for the BME280 lib which I have pull request in for as well as the BN055 lib which is in work. I really like Adafruit boards and libs so this is my way of contributing back.

ladyada commented 7 years ago

thank you kindly :)

mjs513 commented 7 years ago

Thanks for merging. Mike