search

adafruit / Adafruit_TSL2591_Library

This is an Arduino library for the TSL2591 digital luminosity (light) sensors.
58 stars 48 forks source link

Update README.md #29

Closed hoffmannjan closed 5 years ago

hoffmannjan commented 5 years ago

fixed travis links

ladyada commented 5 years ago

@hoffmannjan please fix travis complaint too :)

caternuson commented 5 years ago

Looks like ESP32 is being a little stricter with the compiler flags. This one at least:

/home/travis/arduino_ide/libraries/Adafruit_Test_Library/Adafruit_TSL2591.cpp:326:64: error: 'y' may be used uninitialized in this function [-Werror=maybe-uninitialized]

   y |= read16(TSL2591_COMMAND_BIT | TSL2591_REGISTER_CHAN0_LOW);

seems worth fixing. Wonder if that |= is a typo? Should just be =?

ladyada commented 5 years ago

yes the compilers are getting pickier (which is good :) you can assign y = 0 beforehand, or when its instantiated.

hoffmannjan commented 5 years ago

yeah esp32 is especially picky ;), added fix in #31 thanks @caternuson !

hoffmannjan commented 5 years ago

retriggered the build as It should passes with new master