search

adafruit / Adafruit_TinyUSB_Arduino

Arduino library for TinyUSB
MIT License
469 stars 122 forks source link

add nkrokeyboard support #207

Closed hlcm0 closed 1 year ago

hlcm0 commented 1 year ago

hi hi, thank you for your PR and sorry for late response. I was a bit busy with other works. I saw your issue #205 and #206 . Indeed there is a hipcup with esp32 where it use an older header, we can add an skip file to skip test for esp32 in ci (funhouse, magtag and metroesp32s2) like this example https://github.com/adafruit/Adafruit_TinyUSB_Arduino/tree/master/examples/MassStorage/msc_sd

The rest (samd/nrf) seems to be explicit type case which we can fix with the example. If you are still not sure how to do that, don't worry, just add back the ino file. I will take care of the ci (by pushing fix myself)

I’ve reuploaded the ino file. It uses some new contents that I added in the header file (in this PR). Thank you for hosting this wonderful project and also for helping me to fix this PR!

hlcm0 commented 1 year ago

@hathach i have change the layout of the key and add led input. Tested with the new example(already uploaded, keys are working properly) on RP2040.

the problem now is that though i can't get led indicators working (so i didn't code for it in the example).

I try with the code below, the capslock led didn't turn on when the capslock were pressed. https://github.com/hlcmOxO/Adafruit_TinyUSB_Arduino/blob/test-led-indicator/examples/HID/NKROKeyboard/NKROKeyboard.ino

other part of the NKROKeyboard is all normal. What's wrong with the code(or maybe some problem with the descriptor? )I will be glad if you can tell me how to get the led indicators working.