Adafruit_VL53L0X.cpp file possible typo

adafruit / Adafruit_VL53L0X

Arduino library for Adafruit VL53L0X

149 stars 118 forks source link

Closed mgulsoy closed 5 years ago

mgulsoy commented 5 years ago

In the file Adafruit_VL53L0X.cpp at line 100 it is written:

if( ( DeviceInfo.ProductRevisionMinor != 1 ) && ( DeviceInfo.ProductRevisionMinor != 1 ) )

I think this line should be:

if( ( DeviceInfo.ProductRevisionMajor != 1 ) && ( DeviceInfo.ProductRevisionMinor != 1 ) )

ladyada commented 5 years ago

good question, does it still work for you if you change that line :)

mgulsoy commented 5 years ago

Yes, it works but with the newer v1.15 chips, this line could be an issue.

ladyada commented 5 years ago

ok then please remove the minor revision check and submit a PR, it doesnt make sense to fix a typo that then breaks the code

mgulsoy commented 5 years ago

Ok :) ( By the way, I admire your work @ladyada )

ladyada commented 5 years ago

thanks for the kind note! :)