search

adafruit / Adafruit_VS1053_Library

This is a Arduino library for the Adafruit VS1053 Codec Breakout and Music Maker Shields
https://www.adafruit.com/products/1381
135 stars 113 forks source link

Id3 jumper #49

Closed TheNitek closed 5 years ago

TheNitek commented 5 years ago

Rebased PR #23 and did some minor tweaks (jump ID3 tags when playing file and simplified isMP3File() )

ladyada commented 5 years ago

thanks, what boards did you test this on?

TheNitek commented 5 years ago

Mostly on Esp8266

TheNitek commented 5 years ago

just to also document it here: @leftCoast tested this on teensy in #23

I just tested it successfully on Arduino Uno.

ladyada commented 5 years ago

squahsed and merged!

leftCoast commented 5 years ago

Cool! Now we can move on!

ladyada commented 5 years ago

yes thank you eveyone! you're amazing!

TheNitek commented 5 years ago

Thank you for all your great work @ladyada! And thanks again @leftCoast for this great improvement!

Would it maybe be possible to do a new release of this lib?

ladyada commented 5 years ago

yep! @szymonkaliski wanna practice doing a bump/release? :)

szymonkaliski commented 5 years ago

@ladyada -> https://github.com/adafruit/Adafruit_VS1053_Library/pull/51 :)

ladyada commented 5 years ago

@szymonkaliski ahh sorry added the team as writable, please commit direct and release - then delete the PR :)