Closed paulmand3l closed 10 months ago
@paulmand3l your PR is missing a description of the change, why you made it, and so on. It likely won't move (as time has shown) until you provide the details. Also, the PR is 4 years old, what do you want to do with it? It seems like a small change, but the PR says there are conflicts but I can't see them because they're old.
The description is right between the two bullet points: "Adding a setVolume method with a single parameter to set volume on both channels with one parameter."
Probably no point in adding this now. Will close.
Thank you for creating a pull request to contribute to Adafruit's GitHub code! Before you open the request please review the following guidelines and tips to help it be more easily integrated:
Adding a setVolume method with a single parameter to set volume on both channels with one parameter.
None
Thank you again for contributing! We will try to test and integrate the change as soon as we can, but be aware we have many GitHub repositories to manage and can't immediately respond to every request. There is no need to bump or check in on a pull request (it will clutter the discussion of the request).
Also don't be worried if the request is closed or not integrated--sometimes the priorities of Adafruit's GitHub code (education, ease of use) might not match the priorities of the pull request. Don't fret, the open source community thrives on forks and GitHub makes it easy to keep your changes in a forked repo.
After reviewing the guidelines above you can delete this text from the pull request.