search

adafruit / Adafruit_VS1053_Library

This is a Arduino library for the Adafruit VS1053 Codec Breakout and Music Maker Shields
https://www.adafruit.com/products/1381
133 stars 112 forks source link

Added ESP32 interrupt based buffer feeding #73

Closed juergenpabel closed 2 years ago

juergenpabel commented 3 years ago

An ESP32 compatible interrupt buffer feeder (based on a task running on the other ESP32 core) that was originally implemented based on v1.0.4: https://github.com/danclarke/Adafruit_VS1053_Library/

I merely ported the changes (for this PR).

jwktje commented 2 years ago

Why is this not merged?

juergenpabel commented 2 years ago

Why is this not merged?

Don't know - the project for which I made this PR has been completed for a long time; I didn't even remember this PR...

ladyada commented 2 years ago

this didnt pass CI, lets try to run it again and see what happens

ladyada commented 2 years ago

@juergenpabel can you rebase to master ?

juergenpabel commented 2 years ago

@juergenpabel can you rebase to master ?

Sorry, I already deleted that repository. I created a new fork, ported the patch and created a new PR that will be the continuation of this PR (PR #77). Thus closing this PR.