search

adafruit / Adafruit_VS1053_Library

This is a Arduino library for the Adafruit VS1053 Codec Breakout and Music Maker Shields
https://www.adafruit.com/products/1381
135 stars 113 forks source link

Please fix sdfat #88

Open BiatuAutMiahn opened 1 year ago

BiatuAutMiahn commented 1 year ago

When using with Adafruit's sdfat library, you get errors and it will refuse to compile.

madias123 commented 1 year ago

Meanwhile there is no way to fix all those sdfat problems for all boards: sdfat ist the most incompatible library in the whole Arduino land, caused by "to do one's own thing", so we have: old sdfat version by greiman new sdfat version by greiman teensy one ESP8266 one Adafruit one RP2040 one (mostly ESP8266 one, but not really...) ...and many more.

BiatuAutMiahn commented 1 year ago

Why not target greiman's new repo, or adafruit's. And leave sdfat compatibility for different boards upstream?

Currently I use greiman's...haphazardly.

madias123 commented 1 year ago

Why not target greiman's new repo, or adafruit's. And leave sdfat compatibility for different boards upstream?

Currently I use greiman's...haphazardly.

It's a little bit complicated, because I'm converting an old TAG-MP3-Player-project of mine (STM32duino (Rogers Core), SDFat V1(!) and libraries that I modified in the past using SDfat (like VS1503). Meanwhile, I converted the project step by step as a whole new project, caused by too old libraries used in the original code and too much hacks/tricks and workaround especially for the STM32 (low level). Meanwhile I can use my major IO-Code (reading/writing SD Card, sorting dirs and files, reading outMP3-tags) with just the simple #include <SD.h> because this in in the RP2040 core just a wrapper for sdfat V2! So I'm fine with that.

BiatuAutMiahn commented 1 year ago

Gotcha