adafruit / Adafruit_WavePlayer

Helper friend library for tangling with Wav files
3 stars 3 forks source link

Incorrect "architectures" declaration in library.properties #3

Closed maxgerhardt closed 1 year ago

maxgerhardt commented 1 year ago

Trying to compile a semantically empty sketch using the Adafruit_Arcada.h libraries with

#include <Arduino.h>
#include <Adafruit_Arcada.h>

void setup(){}
void loop(){}

in PlatformIO fails due to a the library dependency finder rejecting to include the therefore needed Adafruit_WavePlayer in this repository (hard dependency here) only declares compatibility with the SAMD architecture

https://github.com/adafruit/Adafruit_WavePlayer/blob/6dec4dfefc8c310ff3ea7bff416abcf38ad112f0/library.properties#L8-L9

and we're compiling fo a nRF52 board. This library is however perfectly compilable for nRF52, and even ESP32 looking at the source code, so the library.properties is wrong.

In fact, your CI already does a build for ESP32 + nRF + SAMD.

The library.properties should be corrected to an appropriate architectures value (* or samd,nRF5,esp32?) to allow PlatformIO's library dependency finder to correctly identify and handle the library. (Same goes for the Arduino IDE I guess).

ladyada commented 1 year ago

thank you! merged