search

adafruit / Adafruit_WebSerial_ESPTool

A Web Serial tool for updating your ESP bootloader.
https://adafruit.github.io/Adafruit_WebSerial_ESPTool/
MIT License
130 stars 64 forks source link

adding noReset() button #297

Closed mikeysklar closed 1 month ago

mikeysklar commented 1 month ago

The Adafruit boards with co-processor (PyPortal, MatrixPortal M4, Metro Airlift and related variants) running passthru code will not connect over serial if reset. This small update adds a small button called "Connect without Reset".

The has been tested with a PyPortal and Feather ESP32-S3. It was working as expected.

mikeysklar commented 1 month ago

@dhalbert

mikeysklar commented 1 month ago

Good thought. The "no reset" on/off logic is confusing for multiple reasons even though it matches the CLI. I'll update the wording.

dhalbert commented 1 month ago

The "no reset" on/off logic is confusing for multiple reasons even though it matches the CLI. I'll update the wording.

Yes, it's kind of a double negative ("enable/disable no reset"). Should the switch be reset off/on, and default to on instead? But that's not so easy to explain either.

mikeysklar commented 1 month ago

@dhalbert - Changed the wording to match the guide pages spelling off Passthrough and to be clearer.

Screenshot 2024-11-04 at 6 48 43 AM

I'm leaving the switch set to off by default. The logic being that the co-processor ESP boards are fading in favor of using ESP32 directly (specs / price).