search

adafruit / Adafruit_WebSerial_ESPTool

A Web Serial tool for updating your ESP bootloader.
https://adafruit.github.io/Adafruit_WebSerial_ESPTool/
MIT License
126 stars 62 forks source link

"noReset" toggle is not working in published version #303

Open dhalbert opened 3 hours ago

dhalbert commented 3 hours ago

@mikeysklar @makermelissa

(Found while helping a user in discord: see https://discord.com/channels/327254708534116352/537365702651150357/1306827591407239248 and preceding)

297 by @mikeysklar added a toggle to suppress trying to send a reset, for use with passthrough updaters like on PyPortal. But it is not working in the published version.

I tested the tip of main locally, which includes #297, and it works fine. If the toggle is on, I see:

ESP Web Flasher loaded.
Connecting...
Connected successfully.
Try hard reset.
No reset requested; skipping hard reset.
...

But the published version at https://adafruit.github.io/Adafruit_WebSerial_ESPTool/ does not work. It has the toggle, but it does not print No reset requested; skipping hard reset. This makes me think that the code checking the status of the checkbox is not working for some reason in the published version. Maybe the document.getElementById() is not working?? I'm not sure how to test this locally.

    // Check for noReset toggle
    const noResetCheckbox = document.getElementById("noReset");
    const noResetEnabled = noResetCheckbox
      ? (noResetCheckbox as HTMLInputElement).checked
      : false;

    if (noResetEnabled) {
      this.logger.log("No reset requested; skipping hard reset.");
      return; // Skip reset if noReset is enabled
    }
mikeysklar commented 2 hours ago

Thanks @dhalbert ... I'll work on this on Friday.