fix : Passthrough logic inside hardReset()

adafruit / Adafruit_WebSerial_ESPTool

A Web Serial tool for updating your ESP bootloader.

https://adafruit.github.io/Adafruit_WebSerial_ESPTool/

MIT License

130 stars 64 forks source link

fix : Passthrough logic inside hardReset() #304

Closed mikeysklar closed 2 weeks ago

mikeysklar commented 2 weeks ago

A small change to read the Passthrough checkbox state directly inside of hardReset(). This is to avoid issuing a reset on passthrough boards (M4 + ESP coprocessor).

This was tested locally, but I believe by forcing a read of the passthrough checkbox the web hosted code will also work.

Hardware successfully tested with this update:

Feather V2 PyPortal

Low risk level of making things worse. The Webserial_ESPTool has not worked in passthrough mode since August 2024.

dhalbert commented 2 weeks ago

oops, minor formatting issue

dhalbert commented 2 weeks ago

I did a shift-reload on the deployed page, but I'm still getting:

ESP Web Flasher loaded.
Connecting...
Connected successfully.
Try hard reset.
[Object.debug:196] Finished read loop
Error: Couldn't sync to ESP. Try resetting.