adafruit / Adafruit_Wippersnapper_Arduino

WipperSnapper is a firmware for creating no-code IoT electronics projects.
https://io.adafruit.com/welcome
MIT License
27 stars 40 forks source link

Regenerate displayconfig.json if erroneous #575

Open tyeth opened 2 months ago

tyeth commented 2 months ago

It's possible for the display config file to be corrupt, at which point the funhouse fails to continue. It's a standard file we generate so this commit regenerates the file if erroneous

tyeth commented 2 months ago

Closes #563

tyeth commented 2 months ago

@brentru this one is also ready for review

brentru commented 2 months ago

@tyeth Can we hold on to this PR until we merge and release what's required for NO-OTA?

tyeth commented 2 months ago

We definitely can, although testing the noota was when I encountered the issue. The partition was corrupt but valid, and displayconfig was corrupt so board stalled (no visual output too obviously)

On Mon, 22 Apr 2024, 16:43 Brent Rubell, @.***> wrote:

@tyeth https://github.com/tyeth Can we hold on to this PR until we merge and release what's required for NO-OTA?

— Reply to this email directly, view it on GitHub https://github.com/adafruit/Adafruit_Wippersnapper_Arduino/pull/575#issuecomment-2069952576, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABTBZ43D5AORF5WTZFJIXZDY6UV3FAVCNFSM6AAAAABGTAH7BSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRZHE2TENJXGY . You are receiving this because you were mentioned.Message ID: @.***>