Adds MIDI Library v5 support

adafruit / Adafruit_nRF52_Arduino

Adafruit code for the Nordic nRF52 BLE SoC on Arduino

Other

623 stars 497 forks source link

Adds MIDI Library v5 support #609

Closed spacenate closed 3 years ago

spacenate commented 3 years ago

Fixes #528

Warning: I am well outside my wheelhouse here ⚠️

I do not know beginTransmission() and endTransmission() methods are for. I see that the MIDI Library's serialMIDI implementation ignores them (https://github.com/FortySevenEffects/arduino_midi_library/blob/d9149d19df867abbf78cfcd37ef9d0e14dedca7f/src/serialMIDI.h#L66), so I tried that here, and it worked! (As far as I can tell). Constructive criticism welcome.

hathach commented 3 years ago

thank you for the PR, sorry for late response, it has been a vacation followed by holiday with lots of things to catch up. I will pull this pr and test it out whenever I could.