Added support for passkey-entry and made some usability improvements

adafruit / Adafruit_nRF52_Arduino

Adafruit code for the Nordic nRF52 BLE SoC on Arduino

Other

623 stars 497 forks source link

Added support for passkey-entry and made some usability improvements #632

Closed ArturA-MS closed 2 years ago

ArturA-MS commented 3 years ago

Our use cases required some additional functionality to exercise passkey-entry pairing and query current connections.

These are meant to be some spot-changes that don't modify any existing behavior but can be used to unblock certain uses. Hopefully they can be useful to others as well.

Quick summary:

Added support for Passkey Entry pairing by handling BLE_GAP_EVT_AUTH_KEY_REQUEST in BLESecurity class.
Added function to AdafruitBluefruit to get all currently connected connection handles.

hathach commented 3 years ago

thanks for submitting PR, I am currently in middle of other works. I will review this when switching back to nrf52. Please be patient in the meanwhile

ArturA-MS commented 3 years ago

No problem! Thanks for the update.

ArturA-MS commented 3 years ago

Hi @hathach, are there any updates as to when this will be able to be reviewed? Thanks for your time.

ArturA-MS commented 2 years ago

Hi @hathach. Apologies for the long hiatus. I just updated the PR, taking your feedback and suggestions. I left the comments open so you can resolve the conversations as you ensure the right modifications were made with the new change. Also, do let me know if you find it necessary to rebase on top of master again since the original fork happened some time ago. Thanks!

ArturA-MS commented 2 years ago

@hathach thank you! I greatly appreciate your help.

hathach commented 2 years ago

Thank you for the PR :)