search

adafruit / Adafruit_nRF52_Bootloader

USB-enabled bootloaders for the nRF52 BLE SoC chips
MIT License
445 stars 401 forks source link

[Bug] `make all` lists boards including `boards.h` and `boards.c` #153

Closed henrygab closed 4 years ago

henrygab commented 4 years ago

Describe the bug Makefile lists boards that are not actually valid board choices.

Set up (please complete the following information)

To Reproduce Steps to reproduce the behavior:

  1. Run make
  2. Review list of boards indicated
    Click to show example output...

henrygab@Monster2:/mnt/c/src/github/adafruit_nrf52_bootloader$ make
You must provide a BOARD parameter with 'BOARD='. Supported boards are:
- ./aramcon_badge_2019
- ./arcade_feather_nrf52840_express
- ./arduino_nano_33_ble
- ./bast_ble
- ./boards.c
- ./boards.h
- ./circuitplayground_nrf52840
- ./clue_nrf52840
- ./electronut_labs_papyr
- ./feather_nrf52832
- ./feather_nrf52840_express
- ./feather_nrf52840_sense
- ./ikigaisense_vita
- ./itsybitsy_nrf52840_express
- ./mdk_nrf52840_dongle
- ./metro_nrf52840_express
- ./nice_nano
- ./ohs2020_badge
- ./particle_argon
- ./particle_boron
- ./particle_xenon
- ./pca10056
- ./pca10059
- ./pca10100
- ./raytac_mdbt50q_rx
- ./waveshare_nrf52840_eval
Makefile:71: *** Invalid BOARD specified.  Stop.

  1. Note that two of those boards are not like the others

Expected behavior Only valid board names are listed.

Additional context This bug was caused by commit cf4efa2c94098908f127699746b5cb9d1538df1d.

The Makefile basically lists all files in the src/boards/ directory: https://github.com/adafruit/Adafruit_nRF52_Bootloader/blob/0b3c515d9e1f78b0acbe1cf7a70b12587792cde3/Makefile#L66

Therefore, if putting any other files in that directory, the Makefile will need to explicitly filter those other files.