search

adafruit / Adafruit_nRF52_Bootloader

USB-enabled bootloaders for the nRF52 BLE SoC chips
MIT License
445 stars 401 forks source link

Add MakerDiary nRF52840 M.2 Module board. #155

Closed nitz closed 4 years ago

nitz commented 4 years ago

Currently, board.mk has CFLAGS additions attempting to undefine CONFIG_NFCT_PINS_AS_GPIOS and SOFTDEVICE_PRESENT. Those flags, when used on this board prevent the use of the NFCT, as per #150.

As the PR currently stands, those CFLAGS additions don't work to correctly undefine the symbols, as the board.mk is included ahead of the default CFLAGS being set.

Perhaps we could use another flag similar to how MCU_SUB_VARIANT is handled, something like USES_NFCT, and NO_SOFTDEVICE to prevent those definitions, allowing the individual boards to skip those at will?

nitz commented 4 years ago

Something like that, that I pushed in 75c8999?

I'm not thrilled with those variable names, but they are at least somewhat descriptive. 🙃

nitz commented 4 years ago

Okay, this is good to go as soon as we can resolve the VID/PID bit. I'm unsure what the standard is for boards that don't have "valid" (is that the right word?) IDs.

xiongyihui commented 4 years ago

@nitz We got a range of PIDs from Seeed Studio. We can use 0x2886:0xf00f for this M2 module.

nitz commented 4 years ago

@nitz We got a range of PIDs from Seeed Studio. We can use 0x2886:0xf00f for this M2 module.

Awesome, thank you, @xiongyihui! I plan to add your Pitaya Go board in the future, too. I saw you're still using the Nordic VID/PID in circuitpython. Any chance you had a pair of PIDs you wanted to give to that board as well?

@hathach This one should be good to go!

xiongyihui commented 4 years ago

@nitz For the bootloader of Pitaya Go, we can use 0x2886:0xf00e. Nordic allows small vendors to use its VID and PIDs . The issue is that one PID may be used by two or more products, which may cause windows driver problem.

nitz commented 4 years ago

@nitz For the bootloader of Pitaya Go, we can use 0x2886:0xf00e. Nordic allows small vendors to use its VID and PIDs . The issue is that one PID may be used by two or more products, which may cause windows driver problem.

Excellent, will do! Thank you @xiongyihui