search

adafruit / Adafruit_nRF52_Bootloader

USB-enabled bootloaders for the nRF52 BLE SoC chips
MIT License
432 stars 381 forks source link

add 833 support for v7 #231

Closed kbladewht closed 2 years ago

jpconstantineau commented 2 years ago

@kbladewht Do you think you will be able to work on this? When referring to #246, your work would benefit all nRF52833 users and the community would really appreciate if the new board you have could be split from this PR and the work you mention in the title of the PR (support for SD V7) be merged in. I suspect that the blocker is indeed that USB VID/PID. Splitting this PR in two would remove the blocker for merging the core of this effort.

Thanks

hathach commented 2 years ago

@jpconstantineau OP seems to be busy atm, if you need this asap, you could check out OP's branch, make update yourself then submit it as PR. Make sure the commmit log is as it is that will give credit to OP. When your PR is merged, github is smart enough to set this PR status to merge as well.

jpconstantineau commented 2 years ago

@hathach Thanks for the comments. I have been busy looking at the circuitpython nrf52833 issues and am close to move towards this. Good to know that github is clever enough to close two PRs if one is the continuation of the other.