search

adafruit / Adafruit_nRF52_Bootloader

USB-enabled bootloaders for the nRF52 BLE SoC chips
MIT License
427 stars 380 forks source link

fix 'array subscript 0 is outside array bounds' for newer gcc versions #273

Closed gibbz00 closed 1 year ago

gibbz00 commented 1 year ago

I'm got the following error when building:

lib/sdk11/components/libraries/bootloader_dfu/bootloader_settings.c: In function 'bootloader_mbr_addrs_populate': lib/sdk11/components/libraries/bootloader_dfu/bootloader_settings.c:45:7: error: array subscript 0 is outside array bounds of 'const uint 32_t[0]' {aka 'const long unsigned int[]'} [-Werror=array-bounds] 45 | if (*(const uint32_t *)MBR_BOOTLOADER_ADDR == 0xFFFFFFFF) compilation terminated due to -Wfatal-errors. cc1: all warnings being treated as errors make: *** [Makefile:393: _build/build-feather_nrf52840_express/bootloader_settings.o] Error 1

Looked around and found this issue over at QMK: https://github.com/qmk/qmk_firmware/issues/17064 The main bug referenced can be found here: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105523

In essence: gcc versions of 12 and above have a regression bug that can be solved by adding the compile flag --param=min-pagesize=0. The surrounding conditional in the commit checks that the flag is supported. (Small adaptations to QMKs fix really; https://github.com/qmk/qmk_firmware/pull/17136/commits/216081043649567fb387f9a9c4cc108ae78f1736)

Anyway, building works well for me with this minor change.

zvrh commented 5 months ago

This problem appeared again on gcc13, and only gcc12 was judged in the code.

https://github.com/adafruit/Adafruit_nRF52_Bootloader/blob/64d8e34567928be295d59fa2a7cc732a734550cb/Makefile#L344-L347