adafruit / Adafruit_nRF52_Bootloader

USB-enabled bootloaders for the nRF52 BLE SoC chips
MIT License
427 stars 380 forks source link

Adds support for the Makerdiary nRF52840 Connect Kit board #309

Closed markbirss closed 11 months ago

markbirss commented 11 months ago

This PR adds support for the Makerdiary nRF52840 Connect Kit board.

Matches the format of the existing Makerdiary Pitaya Go board

https://github.com/adafruit/Adafruit_nRF52_Bootloader/blob/master/src/boards/pitaya_go/board.h

hathach commented 11 months ago

are the changes, ok, i must await makerdiary response?

thanks, it looks good, though you need to add this board to the ci yml as well https://github.com/adafruit/Adafruit_nRF52_Bootloader/blob/master/.github/workflows/githubci.yml

markbirss commented 11 months ago

are the changes, ok, i must await makerdiary response?

thanks, it looks good, though you need to add this board to the ci yml as well https://github.com/adafruit/Adafruit_nRF52_Bootloader/blob/master/.github/workflows/githubci.yml

Sure https://github.com/adafruit/Adafruit_nRF52_Bootloader/pull/311

hathach commented 11 months ago

please push the ci yml changes as part of this pr

markbirss commented 11 months ago

@hathach Ok, i updated githubci.yml

markbirss commented 11 months ago

@hathach

anything else need to be fixed ?

hathach commented 11 months ago

@hathach

anything else need to be fixed ?

vid, pid confirmation

markbirss commented 11 months ago

@hathach

OK, will follow up my request i sent to makerdiary

markbirss commented 11 months ago

@hathach

Response from Makerdiary

Our partner SeeedStudio has assigned us 2886:F001~2886:F00F, and we give nRF52840-Connect-Kit UF2 Bootloader the 2886:F00F.

https://github.com/makerdiary/nrf52840-connectkit/discussions/2#discussioncomment-6605728

markbirss commented 11 months ago

@hathach

I have updated board.h with the confirmed VID:PID