adafruit / Adafruit_nRF52_Bootloader

USB-enabled bootloaders for the nRF52 BLE SoC chips
MIT License
461 stars 415 forks source link

Add support for Electronut Labs Papyr #64

Closed ntavish closed 5 years ago

ntavish commented 5 years ago

Circuitpython port here: https://github.com/adafruit/circuitpython/pull/1798

ntavish commented 5 years ago

Papyr's current draw sometimes spikes over 100mA, so there is a chance of brownout/reset. Circuitpython was rebooting to safe mode if pins aren't set 'correctly' (seen this once or twice). That's why I included boards.h inside usb_desc.h: to increase requested power, and to override PID. Let me know if this is not the preferred approach. I can in a separate PR also cleanup other boards if information about VID/PID is available.

hathach commented 5 years ago

@ntavish does your board draw more than 100 mA in bootloader mode or application mode ? Though I agree we can allow board to overwrite several value of USB.

ntavish commented 5 years ago

Oh you're right, this needs to be application mode :man_facepalming:. My excuse is that I was doing it at 3AM. The other modifications to the USB descriptors, the VID:PID for example are still required though.