Use either -Werror OR -fstack-usage (if STACK_USAGE=1) never both

adafruit / Adafruit_nRF52_Bootloader

USB-enabled bootloaders for the nRF52 BLE SoC chips

MIT License

461 stars 415 forks source link

Use either -Werror OR -fstack-usage (if STACK_USAGE=1) never both #69

Closed pyro9 closed 5 years ago

pyro9 commented 5 years ago

-fstack-usage gives warnings whenever inline ASM is used -Werror makes that an error and causes make to fail

hathach commented 5 years ago

which build/board that causes the issue. I haven't experienced this, or maybe it is the gcc version you are running.

pyro9 commented 5 years ago

It happens with BOARD=feather_nrf52840_express using gcc version 5.2.1 20151202 (release) [ARM/embedded-5-branch revision 231848] (GNU Tools for ARM Embedded Processors) (The one distributed with the Adafruit BSP)

hathach commented 5 years ago

your gcc version is too old, please try to upgrade to at least version 7 and test again. The included in bsp is also old, we plan to upgrade it as well when thing is stable.

gcc (Ubuntu 7.4.0-1ubuntu1~18.04) 7.4.0
Copyright (C) 2017 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

hathach commented 5 years ago

Closed since not reproducible