search

adafruit / Adafruit_nRF8001

Drivers for Adafruit's nRF8001 Bluetooth Low Energy Breakout
109 stars 53 forks source link

Moved to actions, doxygen #27

Open evaherrada opened 4 years ago

evaherrada commented 4 years ago

Not sure what's going on here

PaintYourDragon commented 4 years ago

Not sure what Adafruit_Test_Library is all about, which is throwing the errors. This is weird, trying a rebuild…

evaherrada commented 4 years ago

~@ladyada @PaintYourDragon So I'm not sure why, but it now seems possible the order the includes are in could be the reason that github actions is hanging. I reordered them to how they were before the PR, but when I did that, it hung on the same spot the other ones were. I reverted it and it failed, but in the way I expected~

I don't believe that this is the case anymore

PaintYourDragon commented 4 years ago

Not related to Actions getting stuck, but on the order-of-includes thing: I’ve noticed that clang-format will re-order includes, always putting quoted items (ostensibly in the local directory) above bracketed items (ostensibly installed libraries).

I’ve always tended to follow the opposite convention…bracketed libraries first…as local headers sometimes then pick up on things already defined, not needing to #include the same headers a second time. So there’s a near-certain chance that some amount of code I’ve worked on will break following a clang-format…e.g. if Actions complains about a uint8_t or similar, it’s probably because the code was previously relying on being included first…whereas now it (or ) needs to be explicitly added to the problem header file.

Unrelated tangent, just something I remembered: it’s super 100% okay to global search-and-replace “bool” instead of “boolean” if you come across it in any older code. Vintage Arduino detritus, makes absolutely no difference in the functioning of the code, but there’s always That One Guy On Twitter™ who will complain about the oldschool booleans.

evaherrada commented 4 years ago

@PaintYourDragon That's good to know. Yeah, I think the way you do it makes more sense.