search

adafruit / ArduinoCore-samd

114 stars 116 forks source link

samd51..missing calibration defines #126

Closed GMagician closed 5 years ago

GMagician commented 5 years ago

Samd51 has a special reserved are with calibration values, its address is 0x00800080.

The NVM Software Calibration Area contains calibration data that are determined and written during production test. These calibration values should be read by the application software and written back to the corresponding register.

In this area there are some ADC calibration values that "software" has to load (ADCx BIASCOMP, ADCx BIASREFBUF, ADCx BIASR2R, ...). Since there is no reference to such memory address in this core then I think that these values are never loaded by anyone...

Is not a good solution to add defines for this area?

ladyada commented 5 years ago

sure - please submit a PR for these defines!

GMagician commented 5 years ago

I can do that but where to put file? which name to give him? File hierarchy?

ladyada commented 5 years ago

could put it in the analog header file or the variant?