search

adafruit / ArduinoCore-samd

115 stars 119 forks source link

Fix EINT listing for pin 4 #281

Closed matt-chan closed 3 years ago

matt-chan commented 3 years ago

I think this file doesn't match the circuit diagram listing at https://cdn-learn.adafruit.com/assets/assets/000/047/156/original/circuit_playground_Adafruit_Circuit_Playground_Express_Pinout.png?1507829017.

It causes the interrupt pin checking code in ArduinoLowPower to fail, meaning it won't listen to interrupts from button A. Button B works fine.

matt-chan commented 3 years ago

There's a bunch of other mismatches as well, on D8, D11, A4, SDA, SDL. I don't know if this is a deliberate design decision.

ladyada commented 3 years ago

we probably just forgot them - would you like to update all of the INTs in one PR?

matt-chan commented 3 years ago

Sure. I just committed them.

matt-chan commented 3 years ago

It looks like the failed CI step (hallowing) is because of a download failure. Is there some way to restart it?

ladyada commented 3 years ago

kicked build! @hathach please review when ya have a chance