search

adafruit / ArduinoCore-samd

116 stars 119 forks source link

Proposal to improve WVariant part number define logic #326

Closed Timvrakas closed 2 years ago

Timvrakas commented 2 years ago

I needed this hacky fix to build with the SAME54N20A. Is there a way to use the CMSIS definitions to automatically build the correct list of _ETCChannel enum options? I will try to explore soon. I've managed to get everything building with forks of all the adafruit repos, but I'd rather not have to maintain that complexity if I can help the upstream support a wider range of parts.

ladyada commented 2 years ago

hiya the ifdef change is ok, but please remove the json file :)

Timvrakas commented 2 years ago

Alright, I finally got around to cleaning this up. I fixed the ethernet handler, and added all the -N and -P components such that they get all available TC/TCC channels. (The cleaner way to do this would be to use the _SAMD51_TC7_INSTANCE_ defines, and let the CMSIS header logic enable the right instance defines. But that would be a significant change.)

Thanks!

ladyada commented 2 years ago

done thanks!