search

adafruit / ArduinoCore-samd

116 stars 119 forks source link

QTPy_M0 variant has LED_BUILTIN but there is none #327

Open jerryneedell opened 2 years ago

jerryneedell commented 2 years ago

The variant defines the LEB_BUILTIN on Pin 13 , but there is no LED on the board. https://github.com/adafruit/ArduinoCore-samd/blob/master/variants/qtpy_m0/variant.h#L82

This is not really a problem except that things like the "blink" sketch compile but do't actually work.

hathach commented 2 years ago

since LEB_BUILTIN is widely used in most examples, I guess it is a way to prevent compile error. Not sure how to "fix" this though.

ladyada commented 2 years ago

i think we could remove it