search

adafruit / CircuitPlaygroundFirmata

Custom firmata firmware sketch for the Circuit Playground board.
19 stars 14 forks source link

Remove redundant Firmata include #2

Closed agentolivia closed 7 years ago

agentolivia commented 8 years ago

On Arduino 1.6.12, attempts to load the CircuitPlaygroundFirmata result in many 'multiple definition' errors (also reported in this Adafruit support thread by another user: https://forums.adafruit.com/viewtopic.php?f=58&t=104379&p=522882&hilit=firmata#p522882). As suggested by adafruit_support_mike, the Firmata library is part of the standard Arduino library now and needn't be included explicitly. Sure enough, removing the #include line and re-uploading resulted in a successful upload.

islemaster commented 7 years ago

Looks like this is still an issue. I just encountered this using Arduino 1.8.1, Arduino AVR Boards 1.6.17, Circuit Playground Firmata sketch https://github.com/adafruit/CircuitPlaygroundFirmata/commit/5997c2b153119d5f401ec6458c61f8625522dee5. Removing the include as done in this PR resolves the issue. :+1: