Return unknown commands in hex. Add Release power-down command

adafruit / Logic2-SPIFlash

Basic SPI Flash command decoder for Saleae Logic 2

MIT License

21 stars 14 forks source link

Return unknown commands in hex. Add Release power-down command #1

Closed DominiqueMeus closed 3 years ago

DominiqueMeus commented 3 years ago

I'm having trouble with the analyzer in the latest version and it didn't seem like this was the right place to put the request. (Is it?)

Edit: I'm unable to enter numbers other than 0 into the SPI Flash Settings GUI. When I open the capture of a colleague who has added the analyzer I get the message "Failed to create analyzer "SPI Flash"; it is not currently installed." I reinstalled 2.3.19 and I can now fill in the Address Bytes field again. I'll let Salae know.

tannewt commented 3 years ago

Thanks! I'm seeing the issue of changing the settings as well. I think this is the right place for adding more commands though. I'm happy to take PRs.

DominiqueMeus commented 3 years ago

I reported the broken extension as a bug to saleae and they confirmed extensions are broken in 2.3.20.

tannewt commented 3 years ago

Sorry I didn't merge this sooner. I just added QSPI support and this PR needs to be updated against it.

DominiqueMeus commented 3 years ago

I updated the PR to be compatible with your QSPI changes. I also included an ending address for data commands (courtesy of my colleague). Can you verify if everything is still working as intended? I don't have captures to test every command.