WIP: Fix for crashes when QSPI mode isn't correctly detected

adafruit / Logic2-SPIFlash

Basic SPI Flash command decoder for Saleae Logic 2

MIT License

21 stars 14 forks source link

WIP: Fix for crashes when QSPI mode isn't correctly detected #3

Closed desertsagebrush closed 2 years ago

desertsagebrush commented 3 years ago

This fixes the issues described in #2.

Still marked as WIP right now, due to some slight complexity in handling the 0x6b/Quad-Output Fast Read command from a Micron Flash. Specifically, despite it being a QSPI command, the address is sent using 'normal' SPI, which means that the analyzer needs to read the address normally, and then switch to quad-decode.

tannewt commented 3 years ago

Thanks! Please ping when this is ready for review.

desertsagebrush commented 3 years ago

Sorry for the delay -- Life (and work) have been hectic (and are continuing to be hectic :P). I'll probably get a chance to work on this a bit more next week or so.

tannewt commented 3 years ago

No problem @Wmyers559 ! I hope all is well.

colinoflynn commented 2 years ago

I used this patch to confirm it fixed issue #2 for me - I had some other minor fixes that allowed it to decode a QSPI flash for me. Would be great to see this merged in so it doesn't drift too far from other forks, assuming it's not breaking anything (e.g., no disadvantage to merging now).

tannewt commented 2 years ago

Thanks for the testing @colinoflynn. I'll merge this in as-is and hope you follow up with your additional fixes. I've been out on paternity leave and am happy to add additional maintainers if folks are interested in helping. (I'll be out for 12 weeks in three.)