search

adafruit / RGB-matrix-Panel

Arduino library and example code for the 16x32 RGB matrix panels in the shop
http://www.adafruit.com/products/420
303 stars 145 forks source link

Spurious .github folder warning #26

Closed per1234 closed 6 years ago

per1234 commented 8 years ago

The .github folder added in https://github.com/adafruit/RGB-matrix-Panel/commit/14d8b3c78831c4a03fd67a7a5cb6d860bc37e3da (and apparently to all other Adafruit libraries) causes the warning:

WARNING: Spurious .github folder in 'RGB matrix Panel' library

with Arduino IDE 1.6.6 or greater on every compile, whether the library is included or not. This is annoying and causes confusion for beginners. I would recommend putting the template files in the repository root instead as https://help.github.com/articles/creating-an-issue-template-for-your-repository/ states is allowed.

ladyada commented 6 years ago

@per1234 hiya, why not just just Arduino ignore .github the same way it ignores .git?

per1234 commented 6 years ago

The .github folder has been ignored since arduino-builder 1.3.19 / Arduino IDE 1.6.10: https://github.com/arduino/arduino-builder/commit/18470b99daca196257205eae9396a1f74f2bd6fe

Actually it was done at your request: https://github.com/arduino/arduino-builder/issues/70#issuecomment-227041842 Thanks!

So at this point the issue only exists for people using outdated versions of the Arduino IDE (1.6.6-1.6.9). Since it's only a warning anyway I'd say the issue can definitely be considered resolved. I just forgot about this issue and so I never closed it.

ladyada commented 6 years ago

oh lol, i wasnt watching this repo and just did an issue sweep. well, GOOD WORK PAST US! :D