adafruit / Raspberry-Pi-Installer-Scripts

380 stars 158 forks source link

Adafruit Mini PiTFT 1.3" - 240x240 TFT, console image offset when rotated 90° or 270° #228

Closed grenius closed 1 year ago

grenius commented 2 years ago

When using the pi-tft installer and choosing either 90 or 270° the console image is offset and the "old" console remains on the screen in it's original orientation.

grenius commented 2 years ago

Environment: raspberry pi OS buster

Hardware: raspberry pi zero 2 W / Zero2Go UPS hat / Zero4U USB hub

makermelissa commented 2 years ago

Thanks for the details. The only one of those that I have is the Pi Zero 2 W.

makermelissa commented 1 year ago

Verified with a Pi Zero 2 W using the Desktop installation of Buster, Console install option, and a BrainCraft HAT. I suspect the board doesn't matter and I also suspect it may do the same on bullseye, but perhaps not since it has newer drivers. First one is easy to verify. Yeah, it does it on a Pi 4 as well.

grenius commented 1 year ago

Thanks Melissa, I just borked my zero with a power failure while updating so I'll reinstall with bullseye.

On Thu, Nov 3, 2022, 6:04 PM Melissa LeBlanc-Williams < @.***> wrote:

Verified with a Pi Zero 2 W using the Desktop installation of Buster, Console install option, and a BrainCraft HAT. I suspect the board doesn't matter and I also suspect it may do the same on bullseye, but perhaps not since it has newer drivers. First one is easy to verify.

— Reply to this email directly, view it on GitHub https://github.com/adafruit/Raspberry-Pi-Installer-Scripts/issues/228#issuecomment-1302726826, or unsubscribe https://github.com/notifications/unsubscribe-auth/AF4DHTI3R5ODM3SHS2DXCNLWGQZH3ANCNFSM56JSYPIA . You are receiving this because you authored the thread.Message ID: @.***>

makermelissa commented 1 year ago

Verified it still happens with bullseye and even on lite install. If you can, I'd recommend lite and using FBCP and it should be fine for now.

makermelissa commented 1 year ago

Hmm, I thought I had previously fixed this. I found #129, which changes the driver parameter from rotate to rotation. This appears to fix it. I need to investigate why it was changed back.

makermelissa commented 1 year ago

It looks like it was changed in #157 by me. Unfortunately I never documented why I made that change. My guess it was either:

  1. It broke something for the FBCP install (possibly this issue: #138)
  2. It was an accident.

I need to test to see if there are issues with the desktop if it uses rotation instead of rotate. We may just simply need to have alternate parameters for the console install if it is an issue.

makermelissa commented 1 year ago

Thanks Melissa, I just borked my zero with a power failure while updating so I'll reinstall with bullseye.

For now, you can edit /boot/config.txt and just manually change the parameter name.