search

adafruit / TFTLCD-Library

Arduino library for 8-bit TFT LCDs such as ILI9325, ILI9328, etc
http://www.ladyada.net/products/tfttouchbreakout/ and http://www.ladyada.net/products/tfttouchshield
314 stars 259 forks source link

Fixed Compilation issue due to not datatype assigned for textsize var… #42

Closed manuaatitya closed 4 years ago

manuaatitya commented 4 years ago

1) The following change has been done to remove the compilation error when using the library due to non-declaration of the datatype for the variable "textsize" used in line 115 of the code.

2) I have added the datatype "int" for the variable since the value assigned to it being 1.

3) Images before & after correction of this issue have also been attached.

compile_success error_lcd_library

i-make-robots commented 4 years ago

This is technically correct (in that it compiles). it creates a variable that is never used, wasting 4 bytes of RAM. If the line is removed then everything compiles. The textsize_x and textsize_y are initialized and used in Adafruit_GFX, so everyone is happy.

ladyada commented 4 years ago

ok so this is good to merge, fixes the issue?

i-make-robots commented 4 years ago

Yes, it fixes the issue.

ladyada commented 4 years ago

awesome, thanks!