adafruit / TinyLoRa

LoRaWAN Library
69 stars 38 forks source link

Make frequency selection work as designed #34

Open Jon-Bright opened 4 years ago

Jon-Bright commented 4 years ago

By initializing the frequency table in the header file. Without this, #define-ing a frequency in the sketch has no effect, because that same #define is not present when the library is compiled.

This is one of the options to fix this, but it's not my preferred option - I'll send a PR for my preferred option momentarily.

This option has the advantage that it maintains compatibility with what was previously documented to work - but since that didn't actually work, that's probably of limited value - nobody can have been using it.

Jon-Bright commented 4 years ago

Here's the other, more-preferred option