search

adafruit / TinyLoRa

LoRaWAN Library
69 stars 38 forks source link

allow multi/single channel selection via function not #define #6

Closed ladyada closed 5 years ago

ladyada commented 5 years ago

maybe function is called setChannel() and you pass in an enumerated list of frequencies or MULTICHANNEL?

see this for an example on how to pass in an enumrated list of constants https://github.com/adafruit/Adafruit_VEML6075/blob/master/Adafruit_VEML6075.h#L48 https://github.com/adafruit/Adafruit_VEML6075/blob/master/Adafruit_VEML6075.cpp#L132

brentru commented 5 years ago

should I also make spreading factor & bandwidth selection a separate function?

ladyada commented 5 years ago

yep!

On Oct 18, 2018, at 4:07 PM, brentrubell notifications@github.com wrote:

should I also make spreading factor & bandwidth selection a separate function?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

brentru commented 5 years ago

Added DR and Channel selection to master, closing...