search

adafruit / Wippersnapper_Components

Component Description Models for Adafruit IO Wippersnapper Beta.
MIT License
9 stars 39 forks source link

add LSM9DS1 I2C Component #211

Open Acoustics123 opened 4 months ago

Acoustics123 commented 4 months ago

This pull request adds the Adafruit 9-DOF Accel/Mag/Gyro+Temp Breakout Board - LSM9DS1 board to Wippersnapper_Components.

Product URL: https://www.adafruit.com/product/3387

tyeth commented 4 months ago

Hi @Acoustics123 👋 Thanks for submitting this pull request, and welcome to GitHub!

There are a couple of extra fields required (like published false for in-development components) in the component JSON, and we've recently setup product images to be pulled from the Adafruit store if not uploaded (which is now our preference for Adafruit components).

These requirements are usually checked by CI(continuous integration) in GitGub Actions, also seen in the Checks tab/box, but these are disabled for first time contributers (until a maintainer allows the first CI run which I've now done for you)

Take a look at something like the vl53l0x i2c component as an example, or here's one I'm adding soon in another PR: https://github.com/adafruit/Wippersnapper_Components/pull/183/files

Are you also planning to add the corresponding driver to the main firmware repository https://github.com/adafruit/Adafruit_Wippersnapper_Arduino ? If not then we'll probably leave this unmerged untill the driver gets started/done too by us (I've got one and it's on my long list so am happy to help) or someone (yourself or another contributor).