Add PWM API - Githubissues

brentru commented 2 years ago

Adding PWM API to address https://github.com/adafruit/Wippersnapper_Protobuf/issues/37

Two primary options:

WriteDutyCycle- writes a duty cycle to a pin with a frequency (fixed). Used for LED slider and RGB LED tri-slider.
WriteFrequency - writes a Frequency, in Hz, to a pin with a duty cycle of 50%. Used for piezo buzzers and speakers.

Required before merging:

[x] PWM component schema
[x] Possible we want to define+mark a pin on the board schema as PWM-compatible
[x] Piezo Buzzer component definition
[x] RGB LED component definition
[x] PWM LED component definition

@lorennorman I've marked some of the older prototyping for PWM API within pin.proto as deprecated. Do you think we should delete these unused and unreferenced messages instead?

brentru commented 2 years ago

Noting in this PR that we've discussed deprecation and are moving on. In the future we may want to try reserved fields or attempt this on staging prior to leaving beta program.

brentru commented 2 years ago

@lorennorman I added https://github.com/adafruit/Wippersnapper_Protobuf/pull/100/commits/3cc4901728493abd4e4520a7fc3eb4eedac1b5ff to address writing different duty cycles to different pins for the case of RGB/RGBW LEDs.

If this looks good to go, I'll merge in.

adafruit / Wippersnapper_Protobuf

Add PWM API #100