Update Altitude Type - Githubissues

adafruit / Wippersnapper_Protobuf

Protocol buffer messages for Adafruit.io WipperSnapper Beta

MIT License

0 stars 2 forks source link

Update Altitude Type #130

Closed brentru closed 11 months ago

brentru commented 11 months ago

Updating SENSOR_TYPE_ALTITUDE to match https://github.com/adafruit/Adafruit_Sensor/pull/53

brentru commented 11 months ago

@lorennorman Noting that this will need to be added to:

web frontend (not done)
mqtt broker (not done)
WipperSnapper Library (DONE)
WipperSnapper Components (DONE, already defined)

brentru commented 11 months ago

Noting that we already have altitude defined within WipperSnapper_Components

brentru commented 11 months ago

@tyeth When Loren updates web frontend and MQTT broker, could you test this by updating the BMP280 driver (https://github.com/adafruit/Adafruit_Wippersnapper_Arduino/pull/459/files#diff-fbdee40a3b30c05fec9ab309639e7be55a44cedcbc22ff0aee176c312f7100a0R122) to work with the altitude type?

We may need to update a few drivers

lorennorman commented 11 months ago

@brentru just checked and we're all good on altitude, it exists in the mqtt broker and the web frontend already. @tyeth is good to go to test things out whenever he's ready!

tyeth commented 11 months ago

Made a minor boo-boo, was about to bump version and release, as the latest was weeks old, but it turned out there was a newer release. I've now promoted it to be marked Latest. As a result the version bump in libraries has been done but no changes otherwise, so maybe I leave it there for the next data type addition...

brentru commented 11 months ago

@tyeth Noted, that is ok!