Update I2C Device SensorEvent message format

adafruit / Wippersnapper_Protobuf

Protocol buffer messages for Adafruit.io WipperSnapper Beta

MIT License

0 stars 2 forks source link

Closed brentru closed 2 years ago

brentru commented 2 years ago

NOTE: This pull request contains breaking changes on an unused API.

Primary change: We'll be using I2CDeviceEvent as a way to pack multiple SensorEvent messages from a unique I2C sensor.
Unused SensorEvent message removed from Signal.proto
Removed unused fields from SensorEvent
SensorEvent data only returns a float
Allow repeated SensorEvent within I2CDeviceEvent
Removes unused SensorDetails message

brentru commented 2 years ago

@lorennorman We're OK to merge this?

lorennorman commented 2 years ago

@brentru I added more comments above for clarity, but yes I approved the changes and you're welcome to merge 👍🏽 if you're unswayed by my suggestion.

brentru commented 2 years ago