search

adafruit / Wippersnapper_Protobuf

Protocol buffer messages for Adafruit.io WipperSnapper Beta
MIT License
0 stars 2 forks source link

Add PWM output pin API #7

Closed brentru closed 3 years ago

brentru commented 3 years ago

DRAFT PR: Do not merge yet

Moves PWM API into pin.proto Adds PWMPinEvent message for C2D messages. Removes existing pwm.proto in favor of ConfigurePWMPinRequest and PWMPinEvent in pin.proto

brentru commented 3 years ago

@lorennorman ^ This PR modifies .proto files and did not seem to trigger an action?

Could we please add a workflow for running buf-checks on pull request?

Might want to try adding: on: [pull_request, push] to https://github.com/adafruit/Wippersnapper_Protobuf/blob/master/.github/workflows/buf-checks.yml#L2

EDIT: Added in 1461470

brentru commented 3 years ago

Added in https://github.com/adafruit/Wippersnapper_Protobuf/pull/7/commits/1461470f94d6c73ff16f1c7c01e394376d0d7a05

brentru commented 3 years ago

Looked over this, I think it's OK to merge. I like it more than the previous API