adafruit / Wippersnapper_Protobuf

Protocol buffer messages for Adafruit.io WipperSnapper Beta
MIT License
0 stars 2 forks source link

Split I2CDeviceDeinit out a bit #71

Closed brentru closed 2 years ago

brentru commented 2 years ago

I2CDeviceDeinit is currently performing both an update and delete operation. This pull request adds I2CDeviceUpdateRequest to i2c.proto to allow for an update-only message.

The I2C modal should be able to send either an I2CDeviceUpdateRequest if a device's sensor has new time periods (from the modal) or if a device's sensor is disabled (also from the modal), or an I2CDeviceDeinitRequest to delete the i2c device itself.

I2CDeviceUpdateRequest sub-messages (AHTUpdateRequest, etc..) contain a period_ field , reflecting the return period of the modal.

brentru commented 2 years ago

@lorennorman Requesting a re-review of https://github.com/adafruit/Wippersnapper_Protobuf/pull/71/commits/9c45c4dc81f0e17c051854af3c4b28db917cda73

brentru commented 2 years ago

@lorennorman Note that this reworks the structure of an I2CDeviceInitRequest message, the broker should be updated to support this PR.