adafruit / Wippersnapper_Protobuf

Protocol buffer messages for Adafruit.io WipperSnapper Beta
MIT License
0 stars 2 forks source link

Make I2C sensor messages more generic, reduce maintenance overhead #84

Closed brentru closed 2 years ago

brentru commented 2 years ago

Breaking PR for both client and device Idea: Remove SENSORNAMEUpdateRequest sub-messages to be more generic and avoid adding to the size of this file every time we'd like to add a sensor. Users adding a sensor to the future component definition JSON repo should not need to also update i2c.proto.

Changes:

brentru commented 2 years ago

Did a small pass over this before we start integrating next week.

brentru commented 2 years ago

@lorennorman I changed sensor_period to a uint32 type, is this OK from your side?