search

adafruit / adabot

Adabot is our robot friend who helps Adafruit online
MIT License
13 stars 27 forks source link

Actually apply the adabot patch to remove bad-whitespace from pylint invocation #185

Closed jepler closed 3 years ago

jepler commented 4 years ago

183 put in an adabot patch for removing bad-whitespace from pylint invocations, but I don't think that this causes the patch to actually be applied.

sommersoft commented 4 years ago

Yes, adabot doesn't automatically run the patches. There is no scheduled job to run them.

The patches-via-pull-request approach is to ensure only approved patches can be run. The patches script will not run patches that are not in the GitHub repo as verified via the API.

Anyone with the adabot environment setup should be able to run it with python3 -m adabot.circuitpython_library_patches.

sommersoft commented 4 years ago

I ran a dry run. The skips are due to drift in build.yml, so the diffs don't match. The 2 failures seem to be in-work repos.

(.env) ~/Dev/adabot/adabot:$> python -m adabot.circuitpython_library_patches --dry-run 
                              -p 0003-actions-Remove-bad-whitespace-from-pylint-invocation.patch
.... Beginning Patch Updates ....
.... Working directory: /home/sommersoft/Dev/adabot/adabot
.... Library directory: /home/sommersoft/Dev/adabot/adabot/.libraries/
.... Patches directory: /home/sommersoft/Dev/adabot/adabot/patches/
.... Deleting any previously cloned libraries
.... Running Patch Checks On 252 Repos ....
   . Skipping Adafruit_CircuitPython_AzureIoT: patch does not apply
   . Skipping Adafruit_CircuitPython_BLE_Eddystone: patch does not apply
   . Skipping Adafruit_CircuitPython_DS1841: patch does not apply
   . Skipping Adafruit_CircuitPython_FONA: patch does not apply
   . Skipping Adafruit_CircuitPython_HTS221: patch does not apply
   . Skipping Adafruit_CircuitPython_LPS2X: patch does not apply
   . Skipping Adafruit_CircuitPython_NeoPixel_SPI: patch does not apply
   . Skipping Adafruit_CircuitPython_RockBlock: patch does not apply
   . Skipping Adafruit_CircuitPython_SimpleIO: patch does not apply
   . Skipping Adafruit_CircuitPython_BLE_iBBQ: patch does not apply
   . Skipping Adafruit_CircuitPython_BLE_MIDI: patch does not apply
   . Skipping Adafruit_CircuitPython_NeoPixel: patch does not apply
   . Skipping Adafruit_CircuitPython_Bundle: patch does not apply <-- Not drift related; actually doesn't apply
.... Patch Updates Completed ....
.... Patches Applied: 237
.... Patches Skipped: 13
.... Patches Failed: 2 

.... Patch Check Failure Report ....
>> Repo: Adafruit_CircuitPython_JTAG    Patch: 0003-actions-Remove-bad-whitespace-from-pylint-invocation.patch
   Error: .github/workflows/build.yml: No such file or directory 
>> Repo: Adafruit_CircuitPython_MachXO  Patch: 0003-actions-Remove-bad-whitespace-from-pylint-invocation.patch
   Error: .github/workflows/build.yml: No such file or directory 

.... Patch Apply Failure Report ....
No Failures
jepler commented 4 years ago

What's the next step? I am not familiar with this process and don't know how to continue.

sommersoft commented 3 years ago

Pretty sure this is no longer applicable. Feel free to re-open if I'm wrong.